Make API rate limit reflect reality around rate limit window borders#6497
Open
apata wants to merge 1 commit into
Open
Make API rate limit reflect reality around rate limit window borders#6497apata wants to merge 1 commit into
apata wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
The test fail reveals that the max burst is double the burst limit when the burst falls in the last second of the Nth window and first second of the N+1th window. Same for hourly limit.
This is a known issue with fixed window rate limiting.
This fixes the test assert for now to reflect reality, but in the future, we may want to consider another counter strategy, like gradually refilling.